-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leptos dep with "tracing" feature enabled leads to build error #1
Comments
I'm working on a larger change and will submit a PR. |
Okay great, I was not aware of this bug. I have also worked a bit on the library without pushing the changes as they do not work correctly. Most notably:
I'll await your reply before pushing my changes as they introduce bugs and you may have a better solution. |
I have decided to push the changes as they now work. Feel free to suggest big changes, I'm very open to changing the way the library is currently structured. |
I will close this issue as it is now resolved. |
…odecov-action-3 Bump codecov/codecov-action from 2 to 3
If a user of leptos-icons enables the "tracing" feature of Leptos in his own crate, the build will fail, as the #[component] macro used for all the icon-components cannot find the tracing crate inside leptos-icons. Adding the tracing dependency to leptos-icons, probably behind a similarly named feature should fix that error.
The text was updated successfully, but these errors were encountered: