Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leptos dep with "tracing" feature enabled leads to build error #1

Closed
lpotthast opened this issue Mar 24, 2023 · 4 comments
Closed

Leptos dep with "tracing" feature enabled leads to build error #1

lpotthast opened this issue Mar 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@lpotthast
Copy link
Collaborator

If a user of leptos-icons enables the "tracing" feature of Leptos in his own crate, the build will fail, as the #[component] macro used for all the icon-components cannot find the tracing crate inside leptos-icons. Adding the tracing dependency to leptos-icons, probably behind a similarly named feature should fix that error.

@lpotthast
Copy link
Collaborator Author

I'm working on a larger change and will submit a PR.

@carloskiki
Copy link
Owner

Okay great, I was not aware of this bug. I have also worked a bit on the library without pushing the changes as they do not work correctly. Most notably:

  • using quote! macro to generate the code for each icon
  • using the prettyplease crate to prettify the generated code.
  • Added support for some basic props: size, class, colour, style, and title.

I'll await your reply before pushing my changes as they introduce bugs and you may have a better solution.

@carloskiki
Copy link
Owner

I have decided to push the changes as they now work. Feel free to suggest big changes, I'm very open to changing the way the library is currently structured.

@carloskiki carloskiki added the bug Something isn't working label Mar 24, 2023
@carloskiki carloskiki mentioned this issue Mar 26, 2023
3 tasks
@carloskiki
Copy link
Owner

I will close this issue as it is now resolved.

carloskiki pushed a commit that referenced this issue Oct 8, 2023
…odecov-action-3

Bump codecov/codecov-action from 2 to 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants