Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop building cryptography from source #219

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

stumpylog
Copy link
Contributor

Description:

Related issue (if applicable): refs #217

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • Tests added

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (ecc8655) to head (3d0ee6d).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   99.37%   99.81%   +0.44%     
==========================================
  Files           7       10       +3     
  Lines         794     1064     +270     
==========================================
+ Hits          789     1062     +273     
+ Misses          5        2       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fi

# Mostly for forks, set an output package name for ghcr.io using the repo name
- name: Set ghcr repository name
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly speaking necessary, but makes it easier for forks to build the image and push it to the ghcr.io, so you can just pull an image to test.

Gives an image input like this on a fork and should have both tags enabled on the main repo.

echo "Installing tools" && \
apt-get install -y -qq \
curl sed git && \
echo "Installing python requirements" && \
pip3 install --no-cache-dir -q -r /etc/requirements.txt gunicorn supervisor && \
pip freeze && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As versions aren't locked for a decent number of items, this might be useful to see what was installed in a built image.

@caronc
Copy link
Owner

caronc commented Dec 27, 2024

Thank you for your help, will merge and see how it goes. 🤞

@caronc caronc merged commit 517ba4b into caronc:master Dec 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants