-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop building cryptography from source #219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 99.37% 99.81% +0.44%
==========================================
Files 7 10 +3
Lines 794 1064 +270
==========================================
+ Hits 789 1062 +273
+ Misses 5 2 -3 ☔ View full report in Codecov by Sentry. |
fi | ||
|
||
# Mostly for forks, set an output package name for ghcr.io using the repo name | ||
- name: Set ghcr repository name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly speaking necessary, but makes it easier for forks to build the image and push it to the ghcr.io, so you can just pull an image to test.
Gives an image input like this on a fork and should have both tags enabled on the main repo.
echo "Installing tools" && \ | ||
apt-get install -y -qq \ | ||
curl sed git && \ | ||
echo "Installing python requirements" && \ | ||
pip3 install --no-cache-dir -q -r /etc/requirements.txt gunicorn supervisor && \ | ||
pip freeze && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As versions aren't locked for a decent number of items, this might be useful to see what was installed in a built image.
Thank you for your help, will merge and see how it goes. 🤞 |
Description:
Related issue (if applicable): refs #217
Checklist
flake8
)