Implement dismiss functionality for single notification #63
Conversation
Closes Issue caroso1222#20 Create a `dismiss` method while keeping the `_removeNotification` method for backward compatibilty purposes (for people who might be relying on this method) Also add .vscode to .gitignore
|
Wow, amazing work, thank you! Weekend is wife time but I'll take a look at this first thing on Monday. Thanks again 😃 Just one thing real quick, I see you're adding explicit return types to some functions. I prefer implicit type inference as it makes the code less verbose while still keeping it safe and allowing intellisense. I propose a middle ground, though: enable the flag |
|
I personally prefer explicit return types (particularly in a public codebase) so that I'm aware while changing the API (for an existing method), and that its a conscious decision. This becomes even more crucial when we don't have unit tests that check a particular method in isolation, and prevents cases when we simply forget about the return type and unintentionally change it. Having said that, what you described also makes sense, and I'm more than happy to update the PR - just let me know. |
|
Yes please! if you can update the PR with |
|
@bharatramnani94 I've put some more comments in regards to the testing strategy. I think that's a lot of work for you, feel free to drop the responsibility on me. I can make those changes, but I'll leave the call on you. Thanks again for all the help |
Create a
dismissmethod while keeping the_removeNotificationmethod for backward compatibility purposes (for people who might be relying on this method)Also add .vscode to .gitignore
Closes Issue #20