Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Use inline image class #157

Merged
merged 1 commit into from
May 21, 2021
Merged

STYLE: Use inline image class #157

merged 1 commit into from
May 21, 2021

Conversation

jhlegarreta
Copy link
Contributor

Use inline image class to display images within a paragraph.

Use `inline` image class to display images within a paragraph.
@jhlegarreta jhlegarreta requested review from kaitj and josephmje May 20, 2021 22:40
@jhlegarreta jhlegarreta added the type:template and tools Issue about template and tools label May 20, 2021
@netlify
Copy link

netlify bot commented May 20, 2021

Deploy Preview for carpentries-dmri ready!

Built with commit a090d66

https://deploy-preview-157--carpentries-dmri.netlify.app

@jhlegarreta jhlegarreta added type:formatting Formatting needs to be fixed and removed type:template and tools Issue about template and tools labels May 20, 2021
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented May 20, 2021

Made possible thanks to carpentries/styles#602.

netlify does not seem to render the images inline, and a local build does not either. The above PR only changed an assets file, which dwells upstream. Maybe carpentries-theme needs to be sync'ed to adopt the changes in assets @maxim-belkin ?

@maxim-belkin
Copy link

Yes, the remote theme repository has to be sync'd with carpentries/styles before you can use inline images.

@jhlegarreta jhlegarreta merged commit 20bc944 into carpentries-incubator:main May 21, 2021
@jhlegarreta jhlegarreta deleted the UseInlineImages branch May 21, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:formatting Formatting needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants