Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training set should be test set in boostrapping lesson #27

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Training set should be test set in boostrapping lesson #27

merged 1 commit into from
Oct 1, 2024

Conversation

TakeshiTohyama
Copy link
Contributor

As discussed in #26, the bootstrapping lesson evaluates the performance on the training set instead of the test set.

This pull request :

  • changes training set to test set
  • updates figures to use test set

Closes #26

@tompollard
Copy link
Collaborator

Looks good to me, thanks Takeshi!

@tompollard tompollard merged commit 3a393c9 into carpentries-incubator:gh-pages Oct 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Training set should be test set in boostrapping lesson
2 participants
@TakeshiTohyama @tompollard