Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Writing Scripts and Working with Data #48

Closed
Czirion opened this issue Aug 27, 2022 · 6 comments
Closed

Improve Writing Scripts and Working with Data #48

Czirion opened this issue Aug 27, 2022 · 6 comments
Assignees
Labels
high priority Need to be addressed ASAP status:in progress Contributor working on issue type:discussion Discussion or feedback about the lesson

Comments

@Czirion
Copy link
Collaborator

Czirion commented Aug 27, 2022

Reviewr's comments:

  1. In the Writing Scripts and Working with Data episode, there is no proposed text to write in nano. Although it's understood that this allows for more creativity from the learners, it may be useful to add an example for guidance. Such an example will also assist in the flow of the section on "Writing files", as it is currently a bit unclear.

  2. In the Writing Scripts and Working with Data episode, the sentence "You will learn more about writing scripts in a later lesson." links back to the same episode.

  3. In the Writing Scripts and Working with Data episode, the "Transferring data between your local machine and the cloud" needs to be adapted to also fit the case of a local installation - or be provided with a possible alternative.

  4. In the Writing Scripts and Working with Data episode, the section on "Versioning scripts with Git and GitHub" would lead to a confusion, given the target audience. Although knowledge of Git is undoubtedly a useful skill, it may not be easily connected here.

@Czirion Czirion added status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR and removed status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR labels Aug 27, 2022
@Czirion
Copy link
Collaborator Author

Czirion commented Oct 16, 2022

  1. Added text and screenshot
  2. Removed line
  3. Pending...
  4. Removed Git part

@nselem nselem added the high priority Need to be addressed ASAP label Jan 13, 2023
@fabel134 fabel134 added status:in progress Contributor working on issue type:discussion Discussion or feedback about the lesson labels Jan 17, 2023
@fabel134
Copy link
Collaborator

Creo que ya termine :)

@nselem
Copy link
Collaborator

nselem commented Jan 17, 2023

Please, explain what did you do, for the reviewers

@fabel134
Copy link
Collaborator

This Issue was fixed by adding steps to be able to download and upload data from an R Studio online terminal. Also added a note that talks about alternatives to download and upload data.

@fabel134
Copy link
Collaborator

The sizes of the figures will be adjusted so that they can be readable

@nselem
Copy link
Collaborator

nselem commented Jan 18, 2023

Great work. Now you need to have all images in English. The last ones have a legend "seleccionar archivo" en español and we need all images in English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Need to be addressed ASAP status:in progress Contributor working on issue type:discussion Discussion or feedback about the lesson
Projects
None yet
Development

No branches or pull requests

3 participants