-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review]: metagenomics #11
Comments
Thanks for submitting this lesson to The Carpentries Lab, @AbrahamAvelar, @aaronejaime, @fabel134, @Vanessaarfer, @Czirion, @Bedxxe, @nselem, @EdderDaniel, and @ahmedmoustafa. (@BwanyaBrian doesn't seem to be a valid GitHub ID - @nselem please can you check and reply with the correct handle?) I'll be acting as Editor on this submission, and I aim to work through the Editor checklist before the end of the work week. You can expect further posts to this thread after I have finished that. For now, to ensure that the review process runs as smoothly as possible, please make sure you are subscribed to receive notifications from this thread. On the right sidebar of this page 👉 you should see a section headed Notifications, with a Customize link. You can click on that and make sure that you have the Subscribed option selected, to receive all notifications from the thread. I will open Pull Requests on each of the lesson repositories, to add a badge tracking the status of your submission to the Finally, for ease of future reference, I include here a list of links to all the lessons in this curriculum, which will be considered together in this review thread: |
Thank you for your revision Toby |
Performing the editorial checks on five lesson websites is taking a little longer than I anticipated. I am almost finished, but the working day is already over here and I won't be able to post my responses today. I am confident I will be able to add them here on Monday. Thanks for your patience. |
I've completed the editor checks on all five lessons. Taken together, the responses are quite long so I will post one for each lesson as a separate replies in this thread. Please take some time to read through these responses, and post below if you have any questions about anything I've written. After you have addressed the points raised, please let me know by replying in this thread. When everything in my responses has been addressed, I can begin looking for reviewers for the curriculum. |
Editor checks - Metagenomics Workshop OverviewAccessibility
Images in Extras/Launching you own AMI instances are missing alternative text.
There are some low contrast images in Extras/Launching you own AMI instances. Content
The data on Zenodo is currently licensed CC-BY, and we would like lessons in The Carpentries Lab to use data in the public domain i.e. CC0. CC-BY and data: Not always a good fit gives a good summary of the problems with using the CC-BY license for data, and links out to some other helpful resources (the Dryad and BioMedCentral pages in particular). I think there are two options to explore:
Note about content reproduced from DC Genomics curriculum
Design
RepositoryThe lesson repository includes:
The repository does contain a CC-BY license, but the copyright statement inside should be updated to remove Software and Data Carpentry. I suggest replacing it with:
and
The copyright statement in the footer of the lesson pages themselves should also be adjusted, but that would be taken care of by changing the lesson styling to use The Carpentries Incubator template instead of the Data Carpentry template being used now. I have opened pull requests to introduce these changes.
Please add a list of the maintainers of the lesson to the repository
Structure
Supporting informationThe lesson includes:
These are present but the page needs further modification, to remove instructions specific to the Data Carpentry Genomics lesson from which they are derived.
This is missing but perhaps not required for an overview lesson site like this. General
|
Editor checks - Project organization and managementAccessibility
Two images in
There are a few places where heading levels are skipped within the page content, Several episodes include
Content
See my note about CC0 vs CC-BY in the response for the Workshop Overview lesson. Design
RepositoryThe lesson repository includes:
See my note about the copyright statements in the license file in the response for the Workshop Overview lesson.
Please add a list of the maintainers of the lesson to the repository
Structure
Supporting informationThe lesson includes:
See my note about the setup instructions in the response for the Workshop Overview lesson.
Note about content reproduced from DC Genomics curriculum
General
|
Editor checks - Introduction to the Command Line for MetagenomicsAccessibility
Alt-text is present for all four images in the lesson but is currently not descriptive and can be improved.
Content
See my note about CC0 vs CC-BY in the response for the Workshop Overview lesson. Design
RepositoryThe lesson repository includes:
See my note about the copyright statements in the license file in the response for the Workshop Overview lesson.
Please add a list of the maintainers of the lesson to the repository
Structure
Supporting informationThe lesson includes:
See my note about the setup instructions in the response for the Workshop Overview lesson.
General
|
Editor checks - Introduction to R for MetagenomicsAccessibility
Please add alternative text for the images in this lesson.
The highest heading level in most episodes is
Content
There are no exercises in this lesson. Can you add some? If you don't think they are necessary, please describe the other types of formative assessment that would be used when teaching the lesson in a workshop?
Design
RepositoryThe lesson repository includes:
See my note about the copyright statements in the license file in the response for the Workshop Overview lesson.
Please add a list of the maintainers of the lesson to the repository
Structure
Supporting informationThe lesson includes:
The Setup page still includes the setup instructions for the lesson template, copied over from the Lesson Example site that you based the lesson on. These setup instructions should be replaced with content relevant to the lesson.
Please add a glossary of key terms that appear in the lesson. General
|
Editor checks - Data processing and visualization for metagenomicsAccessibility
The images throughout the lesson have alternative text but in most cases it is very brief and undescriptive. Please expand the alt-text for these figures, so that they are more accessible to screen readers.
Episodes include
Content
In
See my note about CC0 vs CC-BY in the response for the Workshop Overview lesson. Design
RepositoryThe lesson repository includes:
See my note about the copyright statements in the license file in the response for the Workshop Overview lesson.
Please add a list of the maintainers of the lesson to the repository
Structure
Supporting informationThe lesson includes:
Setup instructions are present but the page needs further modification, to remove instructions specific to the Data Carpentry Genomics lesson from which they are derived.
Please add a glossary of key terms that appear in the lesson. General
|
Following up with some more information that I hope will be helpful as you begin to work through the points raised above.
|
Hello Toby,
|
Thank you for raising this, @nselem.
To be clear, I was suggesting only that the authors adjust the license to release the data into the public domain - CC-BY is an appropriate (and excellent) license for the article itself. I do understand that, as authors of the lesson, you are limited in how much control you have over this. We will discuss internally how to proceed here and I will come back with a suggestion soon.
I believe the attribution sections are the only parts that need changing. This is to ensure that you as authors receive the credit you deserve for writing the lesson, rather than The Carpentries. |
Hello Toby, We have finished correcting the issues that you proposed, except that there are 4 pull requests awaiting to be merged because Nelly is not currently available and she is the only one with access to the Introduction to R for Metagenomics repository. We remain attentive to any other corrections or indications. Thank you so much for your review and your comments. All the best, Claudia |
hello |
Thank you @nselem @Czirion and others who have worked to address the points raised in the editorial checks. I am going to run through the checklist again for each of the lessons and will respond here again after that. For now, I want to address the data set question: when the lessons have satisfied the other editorial checks, I will be happy to begin looking for reviewers for the lessons. Although I would prefer to see lessons use data in the public domain (and the requirements of the CC-BY license are largely meaningless for data), I must recognise that:
We will work to improve the documentation, resources, and training we provide around this. That should put us in a better position to expect lesson authors to be able to comply with the requirement for CC0 data before they arrive at The Carpentries Lab. That being said, exploring the Zenodo entry linked from https://carpentries-incubator.github.io/metagenomics-workshop/setup.html, I noticed that you are using the DOI specific to version 2 of the dataset (https://doi.org/10.5281/zenodo.6251246). Although this is currently the most recent version of the data, you would need to update the Setup page if you ever need to create a new version. If you change to using the persistent DOI (https://doi.org/10.5281/zenodo.4285900) in the Setup page, it will always point to the most-recent version, making your curriculum easier to maintain in the long run. I will try to post again soon with updated editorial checklists for each lesson in the curriculum. |
I didn't know there was a persistent zenodo DOI. Thanks for letting us know, I have already updated all references to it. |
Editor checks - Metagenomics Workshop OverviewAccessibility
Some of the contrast is low in the AWS screenshots, but on balance I think it is better to include these screenshots than to omit them, and we really have no power to improve the contrast and accessibility of the AWS interface, so I am satisfied with this aspect of the lesson site. Content
See my previous response about the data set, above. Design
RepositoryThe lesson repository includes:
Structure
Supporting informationThe lesson includes:
The glossary is still missing but as I mentioned before, may not be required for an overview lesson site like this. |
Editor checks - Project organization and managementAccessibility
alternative text fields have been added for the images in the
Content
See my earlier note about the data set. Design
RepositoryThe lesson repository includes:
Structure
Supporting informationThe lesson includes:
|
Editor checks - Introduction to the Command Line for MetagenomicsAccessibility
Thank you for adding alternative text to three of the images. There is one more, which should be present in Exercise 2 of
Content
See my earlier note about the data set. Design
RepositoryThe lesson repository includes:
Structure
Supporting informationThe lesson includes:
|
Editor checks - Introduction to R for MetagenomicsAccessibility
Alternative text is still missing for the images in this lesson. For advice on how to write alt-text for these images, see the resources I linked in previous comments.
The highest heading level in most episodes is still
Content
The table in Exercise 2 (in
See my earlier note about the data set. Design
RepositoryThe lesson repository includes:
Structure
Supporting informationThe lesson includes:
|
Editor checks - Data processing and visualization for metagenomicsAccessibility
A few images in the lesson are still lacking alternative text. I found this resource very helpful when confronted with the challenge of writing alt-text for data visualisations: https://medium.com/nightingale/writing-alt-text-for-data-visualization-2a218ef43f81
Content
See my earlier note about the data set. Design
RepositoryThe lesson repository includes:
Structure
Supporting informationThe lesson includes:
|
Thank you again for the time you have taken to work through the comments I left from the first round of editorial checks: it was a genuine pleasure to work through the lesson sites again and see that so many of the points have been dealt with quickly and effectively. I have posted new editorial checks above, with the majority of remaining issues relating to alternative text for images. If you can spend a bit more time getting those alt-text fields written, these lessons will be ready for review. As always, if you have any questions and/or would like more information about anything I have written above, please reply in this thread and I will be happy to discuss further and ensure that you are able to keep making progress. |
Hello Toby |
Thank you @Czirion and everyone for your work to address my comments from the editorial checks. I'm pleased to be able to pass this over to reviewers. @nselem @Czirion Please add the code below to the
|
@fpsom & @PaulaNietoG thank you for volunteering to review lessons for The Carpentries Lab. Please can you confirm if you are happy to review this Metagenomics curriculum? You can read more about the lesson review process in our Reviewer Guide. |
Thank you so much for these reviews @PaulaNietoG 🙌 If you have any suggestions for the Workshop Overview site, that were not already covered by @fpsom's comments above, please feel free to post those here as well. @AbrahamAvelar, @aaronejaime, @bwanya, @fabel134, @Vanessaarfer, @Czirion, @Bedxxe, @nselem, @EdderDaniel, and @ahmedmoustafa: Reviews are now complete, and you can proceed with making changes and responding to the comments and suggestions whenever you are ready. @PaulaNietoG & @fpsom thank you again for volunteering your time to review this curriculum. Please stay subscribed to this thread, so that you can check changes made in response to your review, and in case the lesson developers need to discuss any of your comments while they incorporate the feedback. |
Dear @tobyhodges @fpsom and @PaulaNietoG
|
Thank you @nselem et al for taking time to address Reviewers' comments, and for providing the itemised list above. @fpsom and @PaulaNietoG: please take some time to look through the updated versions of the lessonsand post back here to let the authors know if there are any additional changes you would like them to make, or if you recommend that we accept the curriculum to The Carpentries Lab. You may find it helpful to refer to the Reviewer checklist again if you would like to use that as a guide. |
Pinging @fpsom and @PaulaNietoG again: have you had time to look through the curriculum, after the authors completed their changes in response to your initial reviews? |
Hello! Everything looks good to me. I recommend that the lesson is accepted. Congratulations on the hard work! |
Hi everyone! Really sorry for the long delay in replying. I will echo @PaulaNietoG; the lesson looks great and I am quite eager to try teaching it :) And many thanks for all your hard work! |
Thank you @PaulaNietoG and @fpsom, this is very exciting. I know it takes considerable time to conduct a review on a whole curriculum like this, and I really appreciate the thorough and thoughtful approach you have both taken to it. I will follow up with you separately to request some feedback on your experience as reviewers. @nselem @AbrahamAvelar, @aaronejaime, @fabel134, @Vanessaarfer, @Czirion, @Bedxxe, @nselem, @EdderDaniel, @bwanya, and @ahmedmoustafa I am delighted to be able to mark the curriculum as approved now. There are a few other steps to take, to transfer the curriculum into The Carpentries Lab and pass on the submission to JOSE. I am traveling today so may not get through everything before the weekend, in which case I will come back to the task at the start of next week. |
Dear @tobyhodges, @PaulaNietoG and @fpsom, thank you for your time and effort that helped us improve the lesson. It has been an enriching experience for the team. @fpsom We hope that soon you can teach the lesson, we will be very happy. |
The lesson repositories have now all all been transferred into The Carpentries Lab. Here are the new repository locations:
Note that some of the repository names have changed, as well as their GitHub organisation. Those of you with local clones of these repositories should update your remotes accordingly (use I also renamed the default branch of
Finally, I recommend that you now publish a new release of each lesson repository to Zenodo. |
By publishing the lesson, do you mean uploading all the local repositories to Zenodo? or just the data? If the answer is the repositories, should be one upload for all the five repositories, or separate uploads for each one? |
I was checking the new websites and it is so exciting to see "This lesson has passed peer-review!" in the lessons! |
Good catch, @Czirion, thanks. That was an unanticipated side effect of renaming the default branch - GitHub Pages was deactivated. It should be back up now. |
At the moment, I think only the data for the curriculum is published on Zenodo. So far, I have set that DOI to be linked from the banner at the top if each lesson site. However, I recommend that you now create a Zenodo entry for each lesson as well, which you can populate with a list of authors, maintainers, reviewers, etc. When those have been made, the If and when the curriculum is accepted to JOSE, we can update the DOIs in the |
Since the curriculum was accepted to JOSE yesterday, I am going to close this issue. Congratulations again to all the reviewers, and thanks one more time to @fpsom and @PaulaNietoG for reviewing 🙌 |
Well done, congratulations! :) |
Thank you for your interest in submitting your lesson for review in The Carpentries Lab!
Please respond to the prompts below to complete your submission.
Check boxes by adding an 'x' between the square brackets at the start of each point,
or submit the issue and check off the boxes afterwards.
What is the title of the lesson?
Metagenomics Workshop Overview
Provide URLs to
The lesson repository:
https://github.com/carpentries-incubator/metagenomics-workshop
The lesson homepage:
https://carpentries-incubator.github.io/metagenomics-workshop/
Briefly describe the lesson (50 words or fewer).
What does it aim to teach and to whom?
This workshop teaches data management and analysis for metagenomics research, including best practices for organizing bioinformatics projects and data and connecting to and using cloud computing. It also provides experience using command-line utilities and tools to analyze sequence quality and R studio and R libraries to compare diversity between samples.
If you are submitting this lesson for review on behalf
of multiple authors, list the GitHub usernames below for
all authors who should receive notifications relating to the review.
AbrahamAvelar, aaronejaime, fabel134, Vanessaarfer, Czirion, Bedxxe, nselem, BwanyaBrian, EdderDaniel, ahmedmoustafa
Provide URLs to workshop webpages and/or an issue
on the lesson repository from any beta pilots of the lesson.
(A beta pilot is a workshop where the lesson was taught
by any instructor who was not part of the lesson development team
before the pilot took place.)
Alpha workshop https://betterlabmx.github.io/2020-11-27-BetterLab/
First beta pilot https://czirion.github.io/2021-06-30-BetterLab-online/
The second beta pilot was a course in a University, Here we provide the letter of the University to the professor: Guanajuato University Letter
(Optional) If you have obtained a DOI for the lesson via Zenodo,
paste that DOI below.
10.5281/zenodo.4285901
If the lesson is similar in topic to any other lesson
already included in The Carpentries Lab and/or
The Carpentries Lesson Programs (Software, Library, and Data Carpentry), briefly describe how this lesson differs and why a separate lesson was developed.
This workshop is a curriculum that comprises four lessons. The first two lessons are adapted to metagenomics from the Genomics’ Data Carpentry. The third part includes a brief introduction to R, and the fourth lesson teaches a complete shotgun metagenomics workflow using public data which was not previously included in The Carpentrie’s lessons but it is a topic of interest to the biological community.
Check the boxes to confirm that the lesson
or that any content derived from another source is reused with permission and appropriate attribution.
If you wish to submit the lesson for publication in
the Journal of Open Source Education (JOSE):
(see the repository README for more details):
paper.md
andpaper.bib
files as described inthe JOSE submission guide for learning modules.
The text was updated successfully, but these errors were encountered: