Update styles 2021-04-14 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will address #544
... by using GFM (GitHub-flavored Markdown) parser (`kramdown-parser-gfm`) instead of the default one (`kramdown`). The default one fails to produce an AST (Abstract Syntax Tree) when there is no blank line before the line with the opening code fence. Related: - gettalong/kramdown#530 - Python-Markdown/markdown#807 Fixes: carpentries/styles#543
Fix Kramdown parser crash
...to make them distinguishable from regular text. And for accessibility!
lesson_check.py allow for missing life_cycle
There are times when the AST is malformed and does not emit a class for the code element. We do not want the parser to crash when this happens, but we also want to notify ourselves that the AST is malformed. This should not result in an error because as we saw in carpentries/styles#543, the parser itself can cause these malformations when the lesson itself renders well. Even though we fixed the previous issue with an updated parser, problems still persist: swcarpentry/r-novice-gapminder#696 (comment) I fully admit that this is a kludge.
I've removed the print condition, because it will just result in an error no matter what (sigh)
Add catch for None type code block in lesson_check
Makefile: fix 'bundle config' command flags
Clean up: 1. `.vendor` directory where Bundler installs all the gems. 2. `.bundle` directory where Bundler stores its settings. 3. `Gemfile.lock` file generated by the Bundler.
Makefile: silence Docker commands
Specifically, set CRAN repository to https://cran.rstudio.com
Fix GitHub actions for lessons in Rmarkdown
Makefile: fix up PHONY targets
add class for images with a drop shadow
Makefile: don't fail when Python isn't found
Fixes the following issue: ``` $ make site lib paths: /Library/Frameworks/R.framework/Versions/3.5/Resources/library Error in install.packages(missing_pkgs, lib = lib, repos = repos) : no packages were specified Calls: install_required_packages -> install.packages Execution halted make: *** [install-rmd-deps] Error 1 ```
bin/dependencies.R: handle 'no packages were specified' error
Update links.md
Closed
This will fix carpentries/styles#576
|
This needs to wait for carpentries/styles#577 to be added to the branch. |
maxim-belkin
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update reorganizes the makefile a bit, adds an image-with-shadow class, updates link colours, updates links, and updates a lot of corner cases.
I updated the styles via the flight rules: https://github.com/carpentries/maintainer-resources/blob/main/FLIGHT_RULES.md#update-styles