Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lesson_check.py --permissive for pre-alpha? #533

Closed
tobyhodges opened this issue Dec 18, 2020 · 3 comments · Fixed by #536
Closed

lesson_check.py --permissive for pre-alpha? #533

tobyhodges opened this issue Dec 18, 2020 · 3 comments · Fixed by #536

Comments

@tobyhodges
Copy link
Member

I'm not so familiar with what's possible in GNU Make or GitHub Actions. Could the Makefile be adjusted such that the lesson_check script is run with the --permissive option for lessons in pre-alpha? Or adjust .github/workflows/website.yml to achieve the same for pull requests/commits made while in pre-alpha? Or is this kind of querying of the _config.yml not really possible in this context?
@zkamvar
Copy link
Contributor

zkamvar commented Dec 18, 2020

If it's specific for pre-alpha, I think it would be better to engineer lesson_check.py to auto-apply the permissive flag for pre-alpha versions. Neither Make or GHA really care about the contents of any files.

zkamvar added a commit to zkamvar/styles that referenced this issue Dec 18, 2020
@zkamvar
permissive checks for pre-alpha lessons
e4d6305 
This will fix carpentries#533
@zkamvar zkamvar mentioned this issue Dec 18, 2020
Merged
fmichonneau pushed a commit that referenced this issue Dec 18, 2020
@zkamvar @fmichonneau
permissive checks for pre-alpha lessons
7fd7d18 
This will fix #533
@ErinBecker
Copy link
Contributor

@AllenDowney - Just wanted to send you a heads up that this should fix some of the problems you've been experiencing with the Astronomy lesson. Thank you for reporting the issue!

@AllenDowney
Copy link

@ErinBecker Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

permissive checks for pre-alpha lessons zkamvar/styles
4 participants
@AllenDowney @zkamvar @tobyhodges @ErinBecker