-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow blank lines and comments when checking links.md
#581
Comments
@maxim-belkin Looks like the described behavior is not observed in other PRs: Not sure why. |
@jhlegarreta, not sure why some runs fail and other don't for you -- don't have the time to look into this at the moment. just an FYI: the |
👍 sounds reasonable. We'll give a try to splitting the links into two files. |
bin/lesson_check.py: allow comments and empty lines in links.md Fixes #581
The
make lesson-check-all
script seems not to allow blank lines and comments in thelinks.md
file according to the following report in acarpentries-incubator
repository:https://github.com/carpentries-incubator/SDC-BIDS-dMRI/pull/142/checks?check_run_id=2400917706#step:16:9
Removing the blank lines and comments in the relevant file:
https://raw.githubusercontent.com/carpentries-incubator/SDC-BIDS-dMRI/master/_includes/links.md
Allows the script to complete its checks about the file naming style, line length, etc.
We introduced blank lines and comments in the
links.md
file to make a clear distinction between the links belonging to the carpentries ecosystem and those specific to the lesson.I ignore whether this impacts other Markdown files of the carpentries ecosystem.
I'd say that the
lesson-check.py
called bylesson-check-all
should allow blank lines and comments in the concerned Markdown files as long as it is a valid Markdown comment.Thanks for such a great tool to check the consistency of a given lesson to the carpentries style.
The text was updated successfully, but these errors were encountered: