Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inconsistent grammar #396

Merged
merged 1 commit into from
Apr 18, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/lesson_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def check_line_lengths(self):
n > MAX_LINE_LEN) and (not l.startswith('!'))]
self.reporter.check(not over,
self.filename,
'Line(s) are too long: {0}',
'Line(s) too long: {0}',
Copy link
Contributor Author

@katrinleinweber katrinleinweber Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could expand this to Line is / Lines are ... but IMHO this is sufficient to avoid the inconsistency Line(s) are ...: 1.

', '.join([str(i) for i in over]))

def check_trailing_whitespace(self):
Expand Down