Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lesson_check.py: report check status at the end #612

Merged

Conversation

maxim-belkin
Copy link
Contributor

Display a message at the end of make lesson-check.
This PR partially addresses #611.
CC @kekoziar

@maxim-belkin
Copy link
Contributor Author

@fmichonneau @zkamvar, I'm going to merge this and other PRs that fix lesson_check.py -- there are several other necessary fixes that depend on changes here.

@maxim-belkin maxim-belkin merged commit 7634a8c into carpentries:gh-pages Jul 12, 2021
@maxim-belkin maxim-belkin deleted the lesson-check-success-message branch July 12, 2021 12:39
@zkamvar
Copy link
Contributor

zkamvar commented Jul 13, 2021

Thank you for this, Maxim! I apologise for not being responsive lately. I was on vacation, at a conference, and then I had to deal with my ISP randomly cutting me off -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants