Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRAN initial submission #3 #84

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Conversation

delosh653
Copy link
Collaborator

Moves cleangrowth example to donttest and adds CRAN comments file. Fixes #83 (Fixing CRAN pretest attempt 2).

@delosh653 delosh653 requested a review from dchud August 17, 2022 17:59
Copy link
Collaborator

@dchud dchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should cran-comments.md maybe just stay attached to #82/#83 instead of including it in the package? It looks like having this file commited to the actual repo kicks up a new note from devtools::check().

Unless this is part of the process, that they want to see the specific comments in a file in the repo with this name... :)

@dchud
Copy link
Collaborator

dchud commented Aug 18, 2022

(...reads more...) ah, so perhaps you're using https://usethis.r-lib.org/reference/use_cran_comments.html? What I don't see is how this file then gets cleaned up from the repo, or if it stays in for future submissions, etc.

@delosh653
Copy link
Collaborator Author

Should cran-comments.md maybe just stay attached to #82/#83 instead of including it in the package? It looks like having this file commited to the actual repo kicks up a new note from devtools::check().

Unless this is part of the process, that they want to see the specific comments in a file in the repo with this name... :)

Whoops, forgot to add it to .Rbuildignore! (added) But the idea of having the markdown be persistent is to have a record of submissions (to also make it easy for future submissions: https://r-pkgs.org/release.html). But I could see wanting to remove the previous submission comments and just have them in git history. Let me know what you want to do on that.

Copy link
Collaborator

@dchud dchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delosh653 delosh653 merged commit 208bdda into carriedaymont:main Aug 18, 2022
@delosh653 delosh653 deleted the cran-pt-3 branch August 18, 2022 17:36
@dchud dchud added this to the v2.0.2 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing CRAN pretest attempt 2
2 participants