New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<uploader> could not download file: 404 Not Found #2517

Closed

hajime-goshima opened this issue Nov 12, 2020 · 0 comments

hajime-goshima commented Nov 12, 2020

I found a problem with URL parsing when downloading.

% is url safe. but, encoded to %25.
https://github.com/carrierwaveuploader/carrierwave/blob/master/lib/carrierwave/downloader/base.rb#L43

This has led to an issue where the PreSigned S3 Object url cannot be accessed.
I'll fix and pull request.

The text was updated successfully, but these errors were encountered:

hajime-goshima added a commit to hajime-goshima/carrierwave that referenced this issue


          fix issue carrierwaveuploader#2517

baa1b4e

This was referenced Nov 12, 2020

Fix issue #2517 #2518

Closed

ActiveRecord::RecordInvalid (Validation failed: [Uploader] could not download file: 500 Internal Server Error) #2505

Closed

mshibuya closed this as completed in

3faf749

joemsak pushed a commit to Kadenze/carrierwave that referenced this issue


          Fix URL escape issues by escaping on URI parse error only

a478287

Fixes carrierwaveuploader#2456, Closes carrierwaveuploader#2457, Fixes carrierwaveuploader#2472, Closes carrierwaveuploader#2473, Fixes carrierwaveuploader#2505, Fixes carrierwaveuploader#2517, Closes carrierwaveuploader#2518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment