Streaming of SanitizedFile. #1529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving or copying a stream, use chunked reading.
Sanitized files need to properly delegate during copy/move.
The streaming function is now safe for legacy clients which don't respect reading in chunks.
|
@TreyE Thanks for this. How would you rework the existing API to properly support this? |
|
@TreyE If you do come back to this, please merge in the master branch, you'll have a better time with Travis testing :) |
|
The way I would re-work the existing file is to allow the File api to accept the standard IO read API. Right now many of them only accept read with 0 arguments. |
|
@TreyE We would welcome a patch for that if you're up for it :) |
|
+1 |
|
@TreyE I'm closing this for now, but feel free to open a new PR if you'd like to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added streaming, where available, for moving/copying of SantizedFile.
This doesn't completely fix the issue with streaming, as that will require a re-work of the existing API to support chunked reads. However, it does keep large files out of memory where possible (e.g. Streaming a large POST body as binary) - at least in the behaviour of sanitized file.
I'm aware there is a fairly bad hack to support the legacy api - but I can't see a way around it without major incompatibilities.