Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids a GET for Google Cloud storage public_urls #2039

Conversation

nikz
Copy link
Contributor

@nikz nikz commented Oct 6, 2016

Hiya!

As I understand it, the public_url method on the Storage class is intended to return a URL without requiring a GET to the backend. At the moment this is how it works for AWS, but for Google Storage the directory.files.get call will make an HTTP request.

I've modified this to use the public access URL as per Google's documentation.

I've also added a very simple spec that's similar to the AWS-specific ones.

Hope this is helpful!

Nik

@mshibuya
Copy link
Member

mshibuya commented Oct 8, 2016

Refs. #1683, 8447886

@mshibuya mshibuya merged commit 68c7317 into carrierwaveuploader:master Oct 8, 2016
@mshibuya
Copy link
Member

mshibuya commented Oct 8, 2016

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants