Avoids a GET for Google Cloud storage public_urls #2039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya!
As I understand it, the
public_url
method on the Storage class is intended to return a URL without requiring a GET to the backend. At the moment this is how it works for AWS, but for Google Storage thedirectory.files.get
call will make an HTTP request.I've modified this to use the public access URL as per Google's documentation.
I've also added a very simple spec that's similar to the AWS-specific ones.
Hope this is helpful!
Nik