Fix issue encountered when trying to reopen a file stored remotely #2185
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add tests? |
|
There you are. |
mshibuya
reviewed
Jul 9, 2017
spec/processing/rmagick_spec.rb
Outdated
| @@ -220,6 +220,38 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe "#rmagick_image", focus: true do | |||
There was a problem hiding this comment.
focus: true needs to be removed.
|
Nice, thanks! |
vprigent
added a commit
to 3print/boilerplate
that referenced
this pull request
Aug 2, 2017
Shall drop as soon as carrierwaveuploader/carrierwave#2185 is ready to be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one tries to reopen a fog-stored file after it has been persisted, they get an error:
This is because the RMagick processor tries to open the file from its
current_path, which in this case is the path on the remote server.This is easily fixed by letting the uploader get the content og the image and send it to
::Magick::Image.from_blob