Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x-stable] - Fix deprecation warning ruby 2.7 #2462

Conversation

aubinlrx
Copy link
Contributor

This PR fix some deprecation warnings introduced with Ruby 2.7.

  • Separation of positional and keyword arguments in Ruby 3.0 source
  • Deprecation of URI.decode link
warning: URI.escape is obsolete
warning: URI.encode is obsolete
  • Deprecation of Kernel.open
calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open

@aubinlrx aubinlrx changed the title [1.x-stable] - Tweak/deprecation warning ruby 2.7 [1.x-stable] - Fix deprecation warning ruby 2.7 Mar 26, 2020
@mshibuya mshibuya merged commit 0712435 into carrierwaveuploader:1.x-stable Oct 4, 2020
@mshibuya
Copy link
Member

mshibuya commented Oct 4, 2020

Thanks!

mshibuya added a commit that referenced this pull request Oct 5, 2020
mshibuya added a commit that referenced this pull request Oct 5, 2020
@digitalmoksha
Copy link

Any possibility of having a new 1.x version cut with the recent changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants