CarrierWave::Storage::Fog#copy_to with Content-Type header #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
reviewed
Jul 25, 2020
lib/carrierwave/storage/fog.rb
Outdated
| connection.copy_object(@uploader.fog_directory, file.key, @uploader.fog_directory, new_path, acl_header) | ||
| options = {} | ||
| options.merge!(acl_header) if acl_header.present? | ||
| options['Content-Type'] ||= content_type if content_type |
There was a problem hiding this comment.
I also saw that we're missing @uploader.fog_attributes. I think we should break this into a separate method? (#2504)
There was a problem hiding this comment.
Thank you, merged
…anhu/carrierwave into stanhu-sh-add-fog-attributes-copy-to
|
We are looking forward to this fix. Any thoughts when this can be merged into the master? |
|
Merged in, thanks! |
This was referenced Feb 21, 2021
This was referenced Mar 11, 2021
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set right Content-Type when copy files from tmp/ directory.
Resolve #2487
Resolve #2484
Resolve #2504