Fix for warning: instance variable @versions_to_* not initialized #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! Any news? |
|
Hey there, just wanted to check in on the status of this PR because it appears it would resolve my issue with CircleCI. Any idea when it would be merged/deployed? |
joemsak
pushed a commit
to Kadenze/carrierwave
that referenced
this pull request
Mar 27, 2021
Fixes carrierwaveuploader#2493, Closes carrierwaveuploader#2506 Memoizing @versions_to_* is unsafe since versions can change dynamically when conditional version is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would resolve #2493