GCS: pass acl_header for public read if fog is public #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not done, uploading a file via carrierwave with fog_public will return access denied. Closes carrierwaveuploader#2426
|
@mshibuya hi! can you look at this PR please? |
|
@yosiat Thanks for your contribution ❤️ . LGTM |
|
@thiagofm thanks a lot :) once we have a release, we will upgrade asap :) |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading from carrierwave 1.3 to 2 we noticed that when we upload to GCS the URL we get is not public, even though we have
fog_public = truein our initializer.After some investigation it looks like the copy_object is not maintaining the ACL, this change is passing the correct ACL if
fog_publicis true.Tested locally and it fixed the issue.
Closes #2426
fog-google pr: fog/fog-google#513