Remove unnecessary counters

carrismetropolitana · Nov 7, 2023 · 073dfe7 · 073dfe7
1 parent 3c9e101
commit 073dfe7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/notifier/index.js b/notifier/index.js
@@ -42,7 +42,7 @@ const RUN_INTERVAL = 30000; // seconds
         //
 
         // Skip if already notified job owner
-        if (jobData.notification_count > 0) continue;
+        if (jobData.date_notified.length > 0) continue;
 
         // Skip if job has no onwer email
         if (!jobData.owner_email) continue;
@@ -56,7 +56,7 @@ const RUN_INTERVAL = 30000; // seconds
         });
 
         // Update status of this job
-        await QUEUEDB.Job.updateOne({ _id: jobData._id }, { $set: { notification_count: jobData.notification_count + 1, date_notified: [...jobData.date_notified, new Date().toISOString()] } });
+        await QUEUEDB.Job.updateOne({ _id: jobData._id }, { $set: { date_notified: [...jobData.date_notified, new Date().toISOString()] } });
 
         // Log progress
         console.log(`→ id: ${jobData._id} | owner_email: ${jobData.owner_email}`);

diff --git a/server/endpoints/download.endpoint.js b/server/endpoints/download.endpoint.js
@@ -22,7 +22,7 @@ module.exports = async (request, reply) => {
   if (!fs.existsSync(`${OUTPUT_DIRECTORY}/${foundRequestedJob._id}.pdf`)) return reply.code(404).send();
 
   // Update download date for this job
-  await QUEUEDB.Job.updateOne({ _id: QUEUEDB.toObjectId(request.params.id) }, { $set: { download_count: foundRequestedJob.download_count + 1, date_downloaded: [...foundRequestedJob.date_downloaded, new Date().toISOString()] } });
+  await QUEUEDB.Job.updateOne({ _id: QUEUEDB.toObjectId(request.params.id) }, { $set: { date_downloaded: [...foundRequestedJob.date_downloaded, new Date().toISOString()] } });
 
   // Read the file to the client
   reply.header('Content-Type', 'application/pdf');

diff --git a/server/endpoints/publish.endpoint.js b/server/endpoints/publish.endpoint.js
@@ -30,9 +30,6 @@ module.exports = async (request, reply) => {
   const newRequestedJob = await QUEUEDB.Job.insertOne({
     // Job status
     status: 'registered',
-    // Counters
-    notification_count: 0,
-    download_count: 0,
     // Timestamps
     date_registered: new Date().toISOString(),
     date_processing: null,