Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding first notebook - basic usage #40

Merged

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented Jun 12, 2024

This PR:

  • adds a first most basic usage notebook
    • this notebooks:
      • builds from the example in README but boils it down even further
      • update the points generator helper and makes it more flexible
      • provides a concise narrative and a clear visual example
  • adds notebooks reqs to pyproject.toml
  • updates .precommit
  • opting to leave the example in the README for now until we are more settled on the notebooks, etc.

  • A follow up notebook will contain a higher dimensional points example
  • What do we thing about including (something like) the points generator as a utility function within the fastpair package? -- One source for demos/notebooks + useful in tests/benchmarking.

xref:

cc @gegen07

@jGaboardi jGaboardi self-assigned this Jun 12, 2024
@carsonfarmer
Copy link
Owner

carsonfarmer commented Jun 12, 2024

  • A follow up notebook will contain a higher dimensional points example

Cool, that seems like a good idea.

  • What do we thing about including (something like) the points generator as a utility function within the fastpair package? -- One source for demos/notebooks + useful in tests/benchmarking.

Yeh that is probably a good idea. Having said that, I wonder if there is a nice module for tests that we could recommend to create various different types of random point patterns? PySAL must have this? Otherwise, just a random point utility module seems reasonable.

@@ -0,0 +1,1116 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@jGaboardi
Copy link
Collaborator Author

Yeh that is probably a good idea. Having said that, I wonder if there is a nice module for tests that we could recommend to create various different types of random point patterns? PySAL must have this? Otherwise, just a random point utility module seems reasonable.

Yes pointpats offers this, as well as a new geopandas that wraps pointpats (Levi & Martin put a ton of work into that). I think these are great option for an advanced use case demo, but the dependencies would really explode if they were to be used in tests.

I think this is worth further discussion and consideration and will open a new ticket for it.

On another note I am thinking that boiling the basic_usage demo even further by having hard-coded points would be an even better intro. Probably move the the random_points function to another demo when that happens. Leave as it for this PR.

@jGaboardi jGaboardi merged commit ee2c8cb into carsonfarmer:main Jun 12, 2024
8 checks passed
@jGaboardi jGaboardi deleted the GH38_move_Features_to_notebook branch June 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants