Do not queue sprites/meshes if there are no views #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
pushed a commit
that referenced
this pull request
Jul 24, 2021
* bevy_sprite2/_pbr2: Do not queue sprites/meshes if there are no views
cart
pushed a commit
that referenced
this pull request
Jul 24, 2021
* bevy_sprite2/_pbr2: Do not queue sprites/meshes if there are no views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my minkraft project I generate a bunch of blocky voxel chunks before spawning the character and camera to ensure there is ground for them to stand on. Unconditionally calling
view_meta.uniforms.binding()assumes there are views and therefore there is a uniform buffer to use in the binding. So without this check, if there are not yet cameras in the scene, this call panics.