fix(fromFetch): don't abort if fetch resolves

Closes ReactiveX#4739
cartant · Apr 26, 2019 · ed8d771 · ed8d771
1 parent 2597e0d
commit ed8d771
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/internal/observable/dom/fetch.ts b/src/internal/observable/dom/fetch.ts
@@ -55,6 +55,7 @@ export function fromFetch(input: string | Request, init?: RequestInit): Observab
     const controller = new AbortController();
     const signal = controller.signal;
     let outerSignalHandler: () => void;
+    let abortable = true;
     let unsubscribed = false;
 
     if (init) {
@@ -73,9 +74,11 @@ export function fromFetch(input: string | Request, init?: RequestInit): Observab
     }
 
     fetch(input, init).then(response => {
+      abortable = false;
       subscriber.next(response);
       subscriber.complete();
     }).catch(err => {
+      abortable = false;
       if (!unsubscribed) {
         // Only forward the error if it wasn't an abort.
         subscriber.error(err);
@@ -84,7 +87,9 @@ export function fromFetch(input: string | Request, init?: RequestInit): Observab
 
     return () => {
       unsubscribed = true;
-      controller.abort();
+      if (abortable) {
+        controller.abort();
+      }
     };
   });
 }