Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ERC-721 information #18

Closed
4 tasks
brunomenezes opened this issue Nov 30, 2023 · 2 comments · Fixed by #19
Closed
4 tasks

Process ERC-721 information #18

brunomenezes opened this issue Nov 30, 2023 · 2 comments · Fixed by #19
Assignees
Labels
Type: Feature Add a new feature to the system

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Nov 30, 2023

📄 Context

Support to the ERC721Portal will be added to the UI, and we can process events from ERC-721 Portal to save handy information to provide consistent support to the UI like we already do with ERC-20.

✔️ Solution

Index metadata about the ERC-721 token passing through the portal. Even if the name and symbol are not implemented as per Spec, we want to know that such a contract address was already used.

Option 1

Add a new Domain:
Domain Name: NFT
Cardinality: 10
Fields: [id: ID!, name: String, symbol: String]

### Option 2
Update the existing Token domain, making the fields name, symbol and decimals optional. Also, Add a field type enumerable ERC20, ERC721 for easy filtering and that specific fields will always be null e.g. ERC-721 spec as per time of writing has no decimals metadata.

EIP-721: https://eips.ethereum.org/EIPS/eip-721

📈 Subtasks

  • Add ERC721 ABI.
  • Index ERC-721 info for inputs coming from ERC721Portal address.
  • Add test case.

🎯 Definition of Done

  • Successfully index the ERC-721 token information.
@brunomenezes brunomenezes added Type: Feature Add a new feature to the system Status: Discussion Collaboratively refine some idea / feature labels Nov 30, 2023
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Nov 30, 2023
@brunomenezes
Copy link
Collaborator Author

@tuler,
What do you think? I am inclined to go with option 1.

@brunomenezes brunomenezes self-assigned this Nov 30, 2023
@brunomenezes brunomenezes removed the Status: Discussion Collaboratively refine some idea / feature label Dec 4, 2023
@brunomenezes
Copy link
Collaborator Author

I am moving with option 1.

@brunomenezes brunomenezes moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Dec 4, 2023
@brunomenezes brunomenezes linked a pull request Dec 12, 2023 that will close this issue
@brunomenezes brunomenezes moved this from 🧑‍💻 In Progress to 👁 In Review in Explorer Unit Dec 12, 2023
@github-project-automation github-project-automation bot moved this from 👁 In Review to 📦 Done in Explorer Unit Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Add a new feature to the system
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant