Feature: Process ERC-721 information #19
Conversation
| const erc20Deposit = await this.handlePayload(input, block, ctx); | ||
| if (erc20Deposit) { | ||
| this.depositStorage.set(inputId, erc20Deposit); | ||
| ctx.log.info(`${inputId} (Erc20Deposit) stored`); | ||
| input.erc20Deposit = erc20Deposit; | ||
| } | ||
|
|
||
| input.erc721Deposit = await this.prepareErc721Deposit( |
There was a problem hiding this comment.
this block of code stayed a little bit different from the token handling above. Is there a way to make it more uniform?
There was a problem hiding this comment.
I think the handlePayload() deserves a bit of refactoring following the steps of prepareErc721Deposit in a separate PR. When I started, I did add the logic inside it. I would return an object with a return like {erc721Deposit: ERC20 } | {erc20Deposit: NFT} so it would be mutually exclusive because the msgSender is 1:1. Also, I was not fond of the duplication on checking if it exists than store/log/assign. I prefer to separate and have a method to take care of everything at once and leave the handle() to control and glue for the Input. That is for the context where I am coming from. I can create an issue and refactor that in a separate branch.
brunomenezes
force-pushed
the
feature/18-process-erc-721-information
branch
from
94d6846 to
d6f236b
Compare
Summary
Code changes to support indexing information from ERC-721 deposits coming from ERC721Portal contract
I created an ERC-721 contract and deployed it on Sepolia to transfer and see the real thing going through.
Contract Address: 0x7a3Cc9c0408887a030A0354330C36a9cd681AA7E
OpenSea: testnet/collection
PS: Now honeypot has a NFT on Sepolia, cartesiScan/apps
Changelog: