#186 Add input completion status #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
nevendyulgerov
commented
Jul 5, 2024
| env: | ||
| E2E_BASE_URL: ${{ github.event.deployment_status.environment_url }} | ||
|
|
||
| - name: Update check status to the outcome |
There was a problem hiding this comment.
Hi, @brunomenezes , I regards to the failing e2e tests, I was expecting the build to fail with the related e2e job as well, but that was not the case. It was passing ok although the e2e job that we run on sepolia preview url was failing.
Because of this I had to implement this step. It will run the reportGitHubStatusCheck script, which will then post an e2e status to the build - "End-to-end (Preview – rollups-explorer-sepolia)". That status can be either success or failure so in the case of the latter the build will fail as well.
brunomenezes
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the input completion status and also covered the new logic with unit tests.