feat: Voucher payload auto decoding #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brunomenezes
force-pushed
the
156-voucher-content-decoding
branch
from
3b0b396 to
6748e5c
Compare
…d of PageableContent it is rather than trust on static function property.
…en switching between RAW and As-JSON Mantine JsonInput throw an silent internal error when switching between raw and as-json mode causing the rendered component to be in its previous state, ignoring the new data passed down.
…tely retrieve the destination contract ABI.
…nment variable is not set.
…or supported chains.
…input-details supporting destination contract link
brunomenezes
force-pushed
the
156-voucher-content-decoding
branch
from
c9e00f6 to
4e1c148
Compare
8 tasks
| ref.current.blur(); | ||
| } | ||
| }, [value]); | ||
| useEffect(() => { |
There was a problem hiding this comment.
This effect will be invoked on each render, if this is desired, we can remove the effect altogether and just run the code at the top-level of that component. Otherwise, we should include an empty array for its dependencies.
There was a problem hiding this comment.
My first option is always not to use a useEffect. The goal is to have a <JsonInput> content formatted, and it does not work when the blur is triggered in the top level. Thus, a "microtask" must run after the content is visible and in-focus.
nevendyulgerov
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to support auto-decoding the voucher payload. As the voucher contains information on the destination (contract address) and the payload (4-byte selector + arguments), we request the destination's ABI and try to decode it using our Specification on the fly. In any failures while hopping into the network or during the decoding attempt, it will gracefully continue to work by just returning and rendering the original raw payload (i.e. Hex). Other changes and refactorings were done along the way.
Changes summary:
JSON-ABIspec type.VoucherExecutioncomponent.CartesiDapp#wasExecutedmethod; Now, thechainIdprop is set instead of relying on underneath logic. That avoids unnecessary error notifications when switching between CartesiScan networks and the wallet is disconnected.InputDetails -> Contentcomponent to fix an internal react error. It loses access to an expected static flag, which causes odd behaviours: it re-renders the previous state of the component (as a perceived fallback).PageableContentit is by passing a param value rather than relying on static function property (PageableContent is shared by the output types, i.e. Notices / Reports / Vouchers)