Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore NoSuchBucket when calling GetBucketAcl #49

Closed
achantavy opened this issue Apr 8, 2019 · 2 comments
Closed

botocore NoSuchBucket when calling GetBucketAcl #49

achantavy opened this issue Apr 8, 2019 · 2 comments
Labels
bug Something isn't working stale stalebot believes this issue/PR is no longer active

Comments

@achantavy
Copy link
Contributor

achantavy commented Apr 8, 2019

File "cartography/sync.py", line 63, in run
    stage_func(neo4j_session, config)
  File "intelmodules/lyft/aws.py", line 200, in lyft_start_aws_ingestion
    common_job_parameters
  File "cartography/intel/aws/__init__.py", line 60, in _sync_multiple_accounts
    _sync_one_account(session, boto3_session, account_id, regions, sync_tag, common_job_parameters)
  File "cartography/intel/aws/__init__.py", line 24, in _sync_one_account
    s3.sync(session, boto3_session, account_id, sync_tag, common_job_parameters)
  File "cartography/intel/aws/s3.py", line 322, in sync
    load_s3_details(neo4j_session, acl_and_policy_data_iter, current_aws_account_id, aws_update_tag)
  File "cartography/intel/aws/s3.py", line 132, in load_s3_details
    for bucket, acl, policy in s3_details_iter:
  File "cartography/intel/aws/s3.py", line 25, in get_s3_bucket_details
    acl = get_acl(bucket, client)
  File "cartography/intel/aws/s3.py", line 53, in get_acl
    acl = client.get_bucket_acl(Bucket=bucket['Name'])
  File "botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "botocore/client.py", line 661, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.NoSuchBucket: An error occurred (NoSuchBucket) when calling the GetBucketAcl operation: The specified bucket does not exist 

Possible race condition - the bucket might have been deleted after the call to get_s3_bucket_list but before get_s3_bucket_details. This crash is similar to #12.

Side note: it would be helpful to add information in the exception messages on which bucket caused this crash.

@achantavy achantavy added bug Something isn't working synccrash labels Apr 8, 2019
@stale
Copy link

stale bot commented Sep 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale stalebot believes this issue/PR is no longer active label Sep 20, 2019
@stale
Copy link

stale bot commented Oct 4, 2019

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new change or reopen this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale stalebot believes this issue/PR is no longer active
Projects
None yet
Development

No branches or pull requests

1 participant