-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #1298 - Add SnipeIT source #1299
Merged
chandanchowdhury
merged 30 commits into
cartography-cncf:master
from
chandanchowdhury:snipeit
Aug 21, 2024
Merged
Fixes: #1298 - Add SnipeIT source #1299
chandanchowdhury
merged 30 commits into
cartography-cncf:master
from
chandanchowdhury:snipeit
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review request |
chandanchowdhury
changed the title
Add Snipeit source
Fixes: #1298 - Add SnipeIT source
Jun 14, 2024
chandanchowdhury
requested review from
heryxpc and
achantavy
and removed request for
heryxpc
July 18, 2024 17:59
achantavy
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits but looks good
achantavy
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding new intel module for SnipeIT source.
Related issues
#1298
Read through our developer docs
If you are modifying or implementing a new intel module
get_
,transform_
,load_
, andcleanup_
functionstransform_
function with sample data (Not applicable)