Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof as felts, added verification on proof parser to tests #66

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

chudkowsky
Copy link
Collaborator

Second Approach to Proof Parser

I implemented the new logic from the feature/fact-registry-integration branch of cartridge-gg/cairo-proof-parser, which separates the handling of Cairo 1 and Cairo 0 proofs. In this update, I made the following changes:

  • Added additional assertions in the tests for better validation coverage.
  • Modified the return type to include proof serialized to felts.

@chudkowsky chudkowsky requested review from piniom and removed request for piniom September 20, 2024 12:07
@chudkowsky chudkowsky merged commit 0466083 into main Sep 23, 2024
4 checks passed
@chudkowsky chudkowsky deleted the feature/cairo-proof-parserV2 branch September 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant