Skip to content

Commit

Permalink
Merge pull request #567 from carvel-dev/cherry-pick-918b2c-v0.31.x
Browse files Browse the repository at this point in the history
Merge pull request #564 from carvel-dev/update-test-completeImgRef

updated test to use complete image ref
  • Loading branch information
joaopapereira authored Aug 21, 2023
2 parents cc5f96d + 3ffcd30 commit 4eda774
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/gcloud_expired_token_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func overrideDockerCredHelperToRandomlyFailWhenCalled(t *testing.T, env *helpers
// Cache the ubuntu image before the gcloud-race-condition-db-error plugin is called.
// test/e2e/assets/docker-credential-gcloud-race-condition-db-error runs a docker command (using the ubuntu:21.04) image. If it isn't cached
// then that plugin will download that image (which takes time), and the keychain will timeout/fail. (We want it to fail for a different reason)
exec.Command("docker", "pull", "ubuntu:21.04").Run()
exec.Command("docker", "pull", helpers.CompleteImageRef("ubuntu:21.04")).Run()

env.AddCleanup(func() {
exec.Command("docker", "volume", "rm", "volume-to-use-when-locking").Run()
Expand Down

0 comments on commit 4eda774

Please sign in to comment.