Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preserve-permission flag to push command #513

Merged
merged 1 commit into from
May 2, 2023
Merged

Add preserve-permission flag to push command #513

merged 1 commit into from
May 2, 2023

Conversation

joaopapereira
Copy link
Member

Fixes #498

@joaopapereira joaopapereira temporarily deployed to GCR e2e April 18, 2023 20:05 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 18, 2023 20:05 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 18, 2023 20:45 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 18, 2023 20:45 — with GitHub Actions Inactive
@joaopapereira joaopapereira mentioned this pull request Apr 18, 2023
Merged
neil-hickey
neil-hickey approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added a question or two around the 07xx permissions we are enforcing by default. Wondering why we are doing that.

praveenrewar
praveenrewar approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/imgpkg/image/tar_image.go Show resolved Hide resolved
pkg/imgpkg/image/dir_image.go Outdated Show resolved Hide resolved
@joaopapereira
Add preserve-permission flag to push command
499432a 
Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e May 2, 2023 14:58 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e May 2, 2023 14:58 — with GitHub Actions Inactive
@joaopapereira joaopapereira merged commit 77f679f into develop May 2, 2023
@joaopapereira joaopapereira deleted the keep-permissions-flag branch May 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-hickey neil-hickey neil-hickey approved these changes

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
3 participants
@joaopapereira @neil-hickey @praveenrewar