Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kctrl: UX enhancements #676

Closed
9 of 11 tasks
100mik opened this issue May 10, 2022 · 2 comments · Fixed by #715
Closed
9 of 11 tasks

kctrl: UX enhancements #676

100mik opened this issue May 10, 2022 · 2 comments · Fixed by #715
Assignees
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@100mik
Copy link
Contributor

100mik commented May 10, 2022

Describe the problem/challenge you have
A bunch of snacky tweaks that will enhance UX. These might be resolved across multiple PRs.

Describe the solution you'd like
Listing AIs in the acceptance criteria

Anything else you would like to add:

  • When a reconciliation completes we should be logging Deploy complete instead of `App reconciled to stay consistent with the other stages
  • Colour app list status column
  • Colour package installed list status output column
  • Conditions in get shouldnt include reason/message when empty (check for missing omitempty tags) (Relevant PR Switch YAML library used to sigs.k8s.io/yaml cppforlife/go-cli-ui#11)
  • Handle invalid package names better (example: kctrl pkg i -i contour -p foo)
  • Explore if we need to leverage wordwrapping for certain columns in list and get commands. This can diverge into a separate issue if it warrants it.

Adding a few more to the list:

  • Add shorthand -v for --version in package installed command.
  • Add namespace name to not found errors.
  • Update package installed list example to use -A instead of A.
  • Update error message to be more user friendly when values and values-file-output flag are used for a package install with no values.yml
  • Update error message for package available get -p <pkg-name> --values-schema to include information about how to specify a version

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@100mik 100mik added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels May 10, 2022
@100mik
Copy link
Contributor Author

100mik commented May 10, 2022

Branched out of #412
An umbrella issue for UX tweaks that are not significant enough to be one by themselves

@100mik 100mik added carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli and removed carvel-triage This issue has not yet been reviewed for validity labels May 10, 2022
@100mik 100mik mentioned this issue May 10, 2022
62 tasks
@100mik 100mik self-assigned this May 10, 2022
@praveenrewar praveenrewar self-assigned this May 10, 2022
@100mik 100mik added the priority/important-soon Must be staffed and worked on currently or soon. label May 31, 2022
@100mik
Copy link
Contributor Author

100mik commented Jun 7, 2022

PR which fixes null messages being printed made to dependency: cppforlife/go-cli-ui#11

@100mik 100mik linked a pull request Jun 13, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants