Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bunch of UX fixes tweaking output #715

Merged
merged 11 commits into from
Jun 13, 2022
Merged

Bunch of UX fixes tweaking output #715

merged 11 commits into from
Jun 13, 2022

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented May 31, 2022 •
edited
Loading

What this PR does / why we need it:

Fixes some kctrl UX issues

Which issue(s) this PR fixes:

Fixes (parts of) #676

Release notes for user facing features:

A bunch of UX improvements for kctrl

Additional Notes for your reviewer:

Adds:

  • Consistent status coloring across commands
  • Corrects misspelt example
Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@100mik 100mik requested a review from praveenrewar May 31, 2022 10:19
@100mik 100mik changed the title Ensure consistent colouring across get and list commands Bunch of UX fixes tweaking output May 31, 2022
@100mik 100mik force-pushed the kctrl-ux-enhancements-1 branch 2 times, most recently from 45aeb6d to bfc466a Compare June 9, 2022 14:12
cppforlife
cppforlife reviewed Jun 10, 2022
View reviewed changes
cli/pkg/kctrl/cmd/app/app.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/app/app.go Outdated Show resolved Hide resolved
cli/pkg/kctrl/cmd/app/get.go Outdated Show resolved Hide resolved
@100mik 100mik linked an issue Jun 13, 2022 that may be closed by this pull request
kctrl: UX enhancements #676
Closed
11 tasks
@cppforlife cppforlife merged commit 1ece87d into develop Jun 13, 2022
@100mik 100mik deleted the kctrl-ux-enhancements-1 branch June 14, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar left review comments

@cppforlife cppforlife cppforlife left review comments

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kctrl: UX enhancements
4 participants
@100mik @cppforlife @praveenrewar @vmwclabot