Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock app deletion when ns is terminating and resources are in the same ns only #1208

Merged
merged 1 commit into from
May 29, 2023
Merged

Unblock app deletion when ns is terminating and resources are in the same ns only #1208

merged 1 commit into from
May 29, 2023

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented May 19, 2023 •
edited
Loading

What this PR does / why we need it:

Unblock app deletion when ns is terminating and resources are in the same ns only. This partially fixes #1132.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@praveenrewar praveenrewar marked this pull request as ready for review May 22, 2023 09:55
@praveenrewar praveenrewar force-pushed the ns-deletion-noop branch 3 times, most recently from c592158 to a579409 Compare May 22, 2023 19:54
neil-hickey
neil-hickey reviewed May 23, 2023
View reviewed changes
pkg/app/app.go Outdated Show resolved Hide resolved
neil-hickey
neil-hickey approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the linter is happy and the small namespace change is made.

@praveenrewar
Unblock app deletion when namespace is terminating
cf316da 
and app resources are in the same namespace only

Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
@praveenrewar praveenrewar merged commit f36a3ce into develop May 29, 2023
@praveenrewar praveenrewar deleted the ns-deletion-noop branch May 29, 2023 05:02
@scothis scothis mentioned this pull request May 30, 2023
Open
@100mik 100mik mentioned this pull request Nov 7, 2023
Closed
@praveenrewar praveenrewar mentioned this pull request Apr 9, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-hickey neil-hickey neil-hickey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable kapp-controller to delete App when namespace is deleted
2 participants
@praveenrewar @neil-hickey