Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fallback to automatic noopDelete if cluster is set #1220

Merged
merged 1 commit into from
May 31, 2023

Conversation

praveenrewar
Copy link
Member

What this PR does / why we need it:

When namespace is terminating

  • Don't fallback to automatic noopDelete if cluster is set
  • Check if the number of namespaces from kapp is 1 and is also the same where the App resides

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@praveenrewar praveenrewar merged commit ded4098 into develop May 31, 2023
@praveenrewar praveenrewar deleted the ns-deletion-noop branch May 31, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants