kctrl: Add secret flag for package repo add/update #1612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Given I have a custom package repository,
And it is hosted on authenticated registry,
When I add a package repository
Then I should be able to specify a secret for registry
kctrl package repository add -r sample-repo --namespace ns --url projects.repo.com/example:1.0.0 --secret repo-secret
And I execute:
kubectl get pkgr sample-repo -oyaml
And I see:
Given I have a package repository created,
When I update the secret for repository
kctrl package repository update sample-repo --secret repo-secret-2
And I run
kubectl get pkgr sample-repo -oyaml
Then I see:
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: