Minor tweaks to package repository #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 25, 2021 10:31
|
With exception of kapp issue, this should close out #237. |
| @@ -61,6 +61,8 @@ func (a *CRDApp) unblockDeletion() error { | |||
| a.log.Info("Unblocking deletion") | |||
| return a.updatePackageRepository(func(app *pkgingv1alpha1.PackageRepository) { | |||
| app.ObjectMeta.Finalizers = removeString(app.ObjectMeta.Finalizers, deleteFinalizerName) | |||
| // Need to remove old finalizer that might have been added by previous versions of kapp-controller | |||
There was a problem hiding this comment.
We should open a corresponding issue for this that captures when we expect to deprecate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.