API server startup does not timeout #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppforlife
reviewed
Apr 12, 2022
cppforlife
reviewed
Apr 12, 2022
This prevents the confusing situation of kapp-controller crashing because the k8s apiserver can't reach us. kapp-controller has a dependency on its own apiserver for the packaging API reconcilers, so if the apiserver fails to come up we will be stuck in a degraded state. We can't use readiness probes or anything like that to signal this degraded state since Kubernetes Services wont route traffic to pods until they are ready.
benmoss
force-pushed
the
no-apiserver-crashloops
branch
from
f498049
to
95c4817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This prevents the confusing situation of kapp-controller crashing because the k8s apiserver can't reach us. kapp-controller has a dependency on its own apiserver for the packaging API reconcilers, so if the apiserver fails to come up we will be stuck in a degraded state.
We can't use readiness probes or anything like that to signal this degraded state since Kubernetes Services wont route traffic to pods until they are ready.
Which issue(s) this PR fixes:
Fixes #607
Does this PR introduce a user-facing change?