rebase rule and e2e tests for pkgrs with identical pkgs #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-kimmel-vmw
commented
Apr 28, 2022
joe-kimmel-vmw
commented
Apr 28, 2022
joe-kimmel-vmw
commented
Apr 28, 2022
joe-kimmel-vmw
commented
Apr 28, 2022
neil-hickey
reviewed
Apr 28, 2022
joe-kimmel-vmw
force-pushed
the
pkgrs-with-identical-packages
branch
from
58907fd
to
9876314
Compare
joe-kimmel-vmw
changed the title
cppforlife
reviewed
Apr 30, 2022
Comment on lines
668
to
1022
| "%s%s%s", | ||
| fmt.Sprintf(pkgrPreamble, 3), | ||
| fmt.Sprintf(pkgTemplate, "shirt-mgr.co.uk", "5.5.5"), | ||
| strings.Replace(fmt.Sprintf(pkgTemplate, "contooor.co.uk", "0.22.0"), "k8slt/kctrl-example-pkg:v1.0.0", "k8slt/some-other-image:latest", -1)) |
There was a problem hiding this comment.
string building throughout tests seem really brittle and quite hard to piece together. lets come up with a different way to adjust inputs.
There was a problem hiding this comment.
happy to talk about it but I didn't immediately see other options I thought were better. it's all compromises, imo, between hardcoding each one fully redundantly on the one end and pumping test artifacts through ytt on the other end.
joe-kimmel-vmw
force-pushed
the
pkgrs-with-identical-packages
branch
3 times, most recently
from
1adb883
to
3566712
Compare
joe-kimmel-vmw
force-pushed
the
pkgrs-with-identical-packages
branch
6 times, most recently
from
c16663c
to
bffb61e
Compare
pkgr templating applies a rebase rule that inserts a noop annotation on a package coming from a PKGR in cases where a package with identical name and contents is already provided by a different repo. - revision annotation allows changes to the package yaml without changing the version - packages that are not identical will still fail to reconcile
helm test seems to be flaky
joe-kimmel-vmw
force-pushed
the
pkgrs-with-identical-packages
branch
from
bffb61e
to
62502bb
Compare
cppforlife
reviewed
Jun 1, 2022
cppforlife
reviewed
Jun 6, 2022
Comment on lines
64
to
74
| fmt.Println(kubectl.Run([]string{"get", "pkg", "pkg.test.carvel.dev.3.0.0-rc.1", "-oyaml"})) | ||
|
|
||
| for i := 1; i < 5; i++ { | ||
| out = kubectl.Run([]string{"get", "packagerepository", pkgrName}) | ||
| fmt.Println(out) | ||
| if strings.Contains(out, "failed") { | ||
| fmt.Println(kubectl.Run([]string{"get", "packagerepository", pkgrName, "-oyaml"})) | ||
| } | ||
| require.NotContains(t, out, "failed") | ||
| time.Sleep(time.Duration(i) * time.Second) | ||
| } |
joe-kimmel-vmw
force-pushed
the
pkgrs-with-identical-packages
branch
from
4d458b9
to
7ae2b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#428