Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --values to kctrl package installed update #683

Merged
merged 6 commits into from
May 31, 2022
Merged

Add --values to kctrl package installed update #683

merged 6 commits into from
May 31, 2022

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented May 11, 2022 •
edited
Loading

What this PR does / why we need it:

This flag allows users to drop values secrets being consumed by a package and remove it's references in a package installation while updating it.
PR also fixes value secret updates clobbering ownership annotations.

Which issue(s) this PR fixes:

Fixes #675

Does this PR introduce a user-facing change?

`--values` can be used to drop values secret being consumed by package install, when no value is provided via `--values-file`

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

@100mik
Copy link
Contributor Author

100mik commented May 11, 2022 •
edited
Loading

This also seems to be affected by #661
i.e. the tail is sometimes not picked up after the changes are applied even though the desired effect is observed on the cluster. This bnehaviour should be corrected with its fix as well.

@100mik 100mik changed the title Add --drop-values-file to kctrl package installed update Add --with-values to kctrl package installed update May 16, 2022
@100mik 100mik changed the title Add --with-values to kctrl package installed update Add --values to kctrl package installed update May 16, 2022
@100mik
Copy link
Contributor Author

100mik commented May 16, 2022

Doc PR here : https://github.com/vmware-tanzu/carvel/pull/439

@100mik
Add '--drop-values-file'
8440f4a
@100mik
Fix: Ownership annotations get clobbered when values secret is updated
a1f939c 
* Fix needed to be able to drop values file that have been updated safely
* Add tests for the same`
@100mik
--drop-values-file => --with-values
bbbe9a6
@100mik
withValues => values. Add an exit case, when there is no values refer…
2f690c8 
…enced.

* values makes more sense since this flag is present in create, update and install
* Making sure an update call is not made if values is false but there are no values to be deleted or no references to be removed
* Update flag descriptions
praveenrewar
praveenrewar approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenrewar praveenrewar merged commit d912f04 into develop May 31, 2022
@neil-hickey neil-hickey deleted the kctrl-drop-values-flag branch June 29, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife cppforlife left review comments

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees

@praveenrewar praveenrewar

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kctrl: Allow users to drop a values secret being consumed by a package install
4 participants
@100mik @cppforlife @praveenrewar @vmwclabot