Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Dockerfile causes ARCH to be ignored during build process #804

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

slapula
Copy link
Contributor

@slapula slapula commented Jul 30, 2022

What this PR does / why we need it:

arm64 support was recently added in #680 however there was a typo in the Dockerfile that sneaked through during the review process. This PR fixes that typo. I have already tested this in my own arm64 environment and was able to produce working images.

Which issue(s) this PR fixes:

Fixes #803

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@vmwclabot
Copy link

@slapula, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@benmoss
Copy link
Contributor

benmoss commented Aug 1, 2022

Thanks for filing this! Are you able to sign the CLA?

@slapula
Copy link
Contributor Author

slapula commented Aug 1, 2022

@benmoss Yup, I have signed it and received the confirmation email.

@benmoss benmoss merged commit 1c921ec into carvel-dev:develop Aug 1, 2022
@vmwclabot
Copy link

@slapula, VMware has approved your signed contributor license agreement.

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x86-64 binaries in the arm64 image
3 participants