Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trivy scan for kctrl #969

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Add trivy scan for kctrl #969

merged 3 commits into from
Nov 29, 2022

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Nov 8, 2022 •
edited
Loading

What this PR does / why we need it:

  • Fix trivy scan
    • Support multiline strings with set-output
    • Use -o=json instead of --to-json in yq
  • Add trivy scan for kctrl

Which issue(s) this PR fixes:

Fixes #845

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

joaopapereira
joaopapereira reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/trivy-scan.yml Show resolved Hide resolved
@praveenrewar
Add trivy scan for kctrl
051ca98
@praveenrewar
Use -o=json instead of --to-json
5bac1e4 
Download only release.yml instead of all release artefacts
neil-hickey
neil-hickey approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenrewar praveenrewar merged commit 1843f99 into develop Nov 29, 2022
@praveenrewar praveenrewar deleted the trivy-scan branch November 29, 2022 20:23
@praveenrewar praveenrewar added the cli Issue for kapp-controller cli label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira left review comments

@neil-hickey neil-hickey neil-hickey approved these changes

Assignees
No one assigned
Labels
cla-not-required cli Issue for kapp-controller cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add trivy scan workflow for kctrl
4 participants
@praveenrewar @joaopapereira @neil-hickey @vmwclabot