Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install imgpkg before running release workflow #986

Merged

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Nov 24, 2022

What this PR does / why we need it:

Since, we have introduced package generation using kctrl, we need imgpkg for the release.

Additional Notes for your reviewer:

We can swap this out when kctrl uses imgpkg as a package. This let's lector; have needed dependencies for the time being

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

@rohitagg2020
Copy link
Contributor

LGTM

Copy link
Contributor

@sethiyash sethiyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@100mik 100mik force-pushed the kctrl-add-imgpkg-to-release-workflow branch from ab4c07a to 3dbbf44 Compare November 24, 2022 15:55
@praveenrewar praveenrewar merged commit 8456447 into carvel-dev:develop Nov 24, 2022
neil-hickey added a commit that referenced this pull request Dec 9, 2022
Install imgpkg before running release workflow (#986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants