Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file path on automated release note generated #991

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

joaopapereira
Copy link
Member

What this PR does / why we need it:

The automated creation of release notes contains paths of the artifacts, but in reality, when uploaded to Github these paths are not preserved.
What this PR accomplishes is removing these paths so that the release notes better match the artifacts locations in Github

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Signed-off-by: João Pereira <joaod@vmware.com>
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the folder structure cleaner

@neil-hickey neil-hickey merged commit d54145f into develop Dec 13, 2022
@neil-hickey neil-hickey deleted the fix-release-note-paths branch December 13, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants