Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version constraint on kind tests #992

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Nov 29, 2022

What this PR does / why we need it:

A version of kind locks onto a version of Kubernetes image. To ensure that we are testing against the latest image available we should use the latest version of kind available via the action

Which issue(s) this PR fixes:

Fixes #971

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@100mik
Copy link
Contributor Author

100mik commented Nov 29, 2022

The new run seems to have the intended effect as opposed to this old one.

@cppforlife cppforlife merged commit 43b6438 into carvel-dev:develop Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should kapp-controller be running tests on latest version of k8s available?
3 participants