refactored code and renamed test method

carvel-dev · May 10, 2022 · 72440b4 · 72440b4
1 parent a5d68cb
commit 72440b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/pkg/kapp/app/recorded_app.go b/pkg/kapp/app/recorded_app.go
@@ -197,13 +197,11 @@ func (a *RecordedApp) create(labels map[string]string, isDiffRun bool) error {
 		return err
 	}
 
-	var dryRunValue []string = nil
-
+	createOpts := metav1.CreateOptions{}
 	if isDiffRun {
-		dryRunValue = []string{metav1.DryRunAll}
+		createOpts.DryRun = []string{metav1.DryRunAll}
 	}
-
-	app, err := a.coreClient.CoreV1().ConfigMaps(a.nsName).Create(context.TODO(), configMap, metav1.CreateOptions{DryRun: dryRunValue})
+	app, err := a.coreClient.CoreV1().ConfigMaps(a.nsName).Create(context.TODO(), configMap, createOpts)
 
 	a.setMeta(*app)
 

diff --git a/test/e2e/diff_test.go b/test/e2e/diff_test.go
@@ -376,7 +376,7 @@ data:
 	require.Containsf(t, out, expectedOutput, "Did not find expected diff output")
 }
 
-func TestKappNotCreateConfigmapOnDiffRun(t *testing.T) {
+func TestDiffRun(t *testing.T) {
 	env := BuildEnv(t)
 	kapp := Kapp{t, env.Namespace, env.KappBinaryPath, Logger{}}
 	kubectl := Kubectl{t, env.Namespace, Logger{}}