Add waiting behavior for PackageRepository/PackageInstalls

[danielhelfand]

Describe the problem/challenge you have

Similar to how kapp has waiting behavior for kapp-controller's App custom resource, kapp should wait for PackageRepository and PackageInstall custom resources.

Currently, PackageRepositories and PackageInstalls will show as successfully created by kapp regardless of whether they have reconciled successfully.

Describe the solution you'd like

When I create/update a PackageRepository/PackageInstall with kapp, kapp should tell me if there is a failure during reconciliation.

Anything else you would like to add:

Steps to reproduce this behavior are to create a PackageRepository/PackageInstall with some misconfiguration that will cause an error during reconciliation.

In the example below for PackageRepo, the image property under imgpkgBundle does not exist. This will cause kapp to successfully create the PackageRepo and no error to be reported during reconciliation.

---
apiVersion: packaging.carvel.dev/v1alpha1
kind: PackageRepository
metadata:
  name: e2e-repo.test.carvel.dev
  namespace: kapp-controller-packaging-global
spec:
  fetch:
    imgpkgBundle:
      image: index.docker.io/k8slt/i-dont-exits 

The kapp-controller App CR can be used as a reference for the expected behavior (i.e. the example for App should produce an error and illustrate how kapp should behave for PackageRepos/PackageInstalls:

---
apiVersion: kappctrl.k14s.io/v1alpha1
kind: App
metadata:
  name: app-failure
spec:
  serviceAccountName: default-ns-sa
  fetch:
    imgpkgBundle:
      image: k8slt/i-dont-exist
  template:
    - ytt: {}
  deploy:
    - kapp: {}

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.